AlexisBRENON commented on code in PR #49768:
URL: https://github.com/apache/airflow/pull/49768#discussion_r2745617666
##########
providers/google/src/airflow/providers/google/cloud/transfers/s3_to_gcs.py:
##########
@@ -335,7 +336,15 @@ def submit_transfer_jobs(self, files: list[str], gcs_hook:
GCSHook, s3_hook: S3H
return job_names
- def execute_complete(self, context: Context, event: dict[str, Any]) ->
None:
+ @overload
+ def execute_complete(self, context: Context, event: dict[str, Any], files:
None) -> None: ...
+ @overload
+ def execute_complete(
+ self, context: Context, event: dict[str, Any], files: Iterable[str]
+ ) -> list[str]: ...
+ def execute_complete(
+ self, context: Context, event: dict[str, Any], files: Iterable[str] |
None = None
+ ) -> list[str] | None:
Review Comment:
You get it right. I tried to make the `files` list available in the
`execute_complete` to be able to return it and so make it available to
subsequent tasks.
Passing it through the Trigger and then the `event` dict may be a solution,
that would avoid to change the signature of the `execute_complete`. But, can
you explain why you think it's a better solution (which is not typed) instead
of using regular kwargs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
