henry3260 commented on PR #61242: URL: https://github.com/apache/airflow/pull/61242#issuecomment-3823077593
> @jason810496 Previously 1 CI failed so, I have updated the timeout to 120 seconds as suggested (and actually pushed it as the default). > > Quick follow-up on the approach: Currently, if the collector isn't reachable after the timeout, the `setup_class` continues but the individual OTel tests will eventually fail assertions. > > Would you prefer if I modified this to return a boolean and use `pytest.skip` in `setup_class` if the collector is unreachable? This would turn those hard failures into "Skipped" status, keeping the CI cleaner when the OTel infrastructure has transient issues. Let me know what you think! +1 on returning a boolean. However, I'm not entirely sure about skipping the tests. If the collector is supposed to be running but isn't reachable, I feel it might be better to let the tests fail (or fail explicitly) so we don't overlook infrastructure issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
