nathadfield commented on PR #61063:
URL: https://github.com/apache/airflow/pull/61063#issuecomment-3823595256
Hi @guan404ming, thanks for reviewing!
The UI changes are minimal and directly implement what's described in the
PR. All three Clear dialog files received identical changes:
1. Fetch global config via useConfig("run_on_latest_version")
2. Implement precedence logic (DAG-level → Global → System default)
3. Apply to checkbox default - Changed from hardcoded useState(false) to
useState(defaultRunOnLatestVersion)
4. Handle async config loading with useEffect
Bug fix included: Changed bundle version comparison from incorrect
taskInstance.dag_version?.bundle_version to correct
taskInstance.dag_run_bundle_version.
Regarding screenshot/demo, the visual change is subtle - it only affects the
default state of the existing "**Run on Latest Version**" checkbox (checked vs
unchecked based on config). The checkbox UI itself is unchanged.
- Before: Always defaults to unchecked
- After: Defaults based on DAG config → Global config → unchecked
I can post a short video that demonstrates that the checkbox is checked
automatically when the config is set if that would help?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
