KL-2300032590 commented on code in PR #61235:
URL: https://github.com/apache/airflow/pull/61235#discussion_r2749204033
##########
providers/postgres/tests/unit/postgres/hooks/test_postgres.py:
##########
@@ -1272,3 +1272,7 @@ def test_dialect_name(self):
def test_dialect(self):
assert isinstance(self.db_hook.dialect, PostgresDialect)
+
+ def test_postgres_hook_invalid_conn_id():
+ with pytest.raises(Exception):
+ PostgresHook(postgres_conn_id=None)
Review Comment:
point on the exception type — I’ll update the test to assert an
Airflow-specific exception (AirflowException) instead of the generic
Exception..&
Indentation is correct here, but I’ll push the exception fix shortly and
update the PR.
Appreciate the guidance!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
