dabla commented on code in PR #61143:
URL: https://github.com/apache/airflow/pull/61143#discussion_r2749286315
##########
providers/common/sql/src/airflow/providers/common/sql/operators/generic_transfer.py:
##########
@@ -196,15 +205,8 @@ def execute_complete(
self.log.info("Offset increased to %d", offset)
context["ti"].xcom_push(key="offset", value=offset)
- self.log.info("Inserting %d rows into %s", len(results),
self.destination_conn_id)
- self.destination_hook.insert_rows(
- table=self.destination_table, rows=results,
**self.insert_args
- )
- self.log.info(
- "Inserting %d rows into %s done!",
- len(results),
- self.destination_conn_id,
- )
+ rows = self._process_rows(rows=rows, context=context)
+ self._insert_rows(rows=rows, context=context)
Review Comment:
Yes, good point, that should become even more DRY.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
