shahar1 commented on code in PR #61284:
URL: https://github.com/apache/airflow/pull/61284#discussion_r2749544554
##########
providers/google/src/airflow/providers/google/cloud/transfers/calendar_to_gcs.py:
##########
@@ -19,7 +19,7 @@
import json
from collections.abc import Sequence
from tempfile import NamedTemporaryFile
-from typing import TYPE_CHECKING, Any
+from typing import TYPE_CHECKING, Any, Union
Review Comment:
```suggestion
from typing import TYPE_CHECKING, Any
```
##########
airflow-core/docs/administration-and-deployment/plugins.rst:
##########
@@ -351,3 +351,4 @@ For example, to print all routes, run:
.. code-block:: bash
FLASK_APP=airflow.www.app:create_app flask routes
+
Review Comment:
I assume it was added by mistake - please revert this change as it is
unrelated to this PR
##########
providers/google/src/airflow/providers/google/cloud/transfers/calendar_to_gcs.py:
##########
@@ -159,9 +173,9 @@ def _upload_data(
object_name=dest_file_name,
filename=temp_file.name,
)
- return dest_file_name
+ return f"gs://{self.destination_bucket}/{dest_file_name}"
- def execute(self, context):
+ def execute(self, context) -> Union[str, list[str]]:
Review Comment:
```suggestion
def execute(self, context) -> str | list[str]:
```
##########
providers/google/src/airflow/providers/google/marketing_platform/operators/display_video.py:
##########
@@ -23,7 +23,7 @@
import tempfile
import zipfile
from collections.abc import Sequence
-from typing import TYPE_CHECKING, Any
+from typing import TYPE_CHECKING, Any, Union
Review Comment:
```suggestion
from typing import TYPE_CHECKING, Any
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
