OscarLigthart commented on PR #59764: URL: https://github.com/apache/airflow/pull/59764#issuecomment-3828848860
@ephraimbuddy @jedcunningham @ashb - I moved the logic out of the serialization. As for moving the logic completely to the `clear_task_instances` method, I opted to diverge a bit from this. It felt weird to me to retrieve a different list of tasks in that function to then completely ignore what was passed originally. Instead, I added a function `get_new_tasks` where this is happening, and am calling it instead of the `SerializedDag._get_task_instances` in case of `only_new=True`. The function lives next to the `clear_task_instances`. @ephraimbuddy let me know if this suffices, or whether you strictly want to keep the updating of dagrun's dag versions in the previously mentioned function. In that case, I will go ahead with moving it there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
