bugraoz93 commented on code in PR #61294:
URL: https://github.com/apache/airflow/pull/61294#discussion_r2750083766
##########
dev/README_RELEASE_HELM_CHART.md:
##########
@@ -485,29 +467,51 @@ AIRFLOW_REPO_ROOT=$(pwd -P)
```shell
VERSION=12.0.1
VERSION_SUFFIX=rc1
+VERSION_RC=${VERSION}${VERSION_SUFFIX}
```
3. Check-out the branch from which the release was made and cleanup dist
folder:
```shell
-git checkout helm-chart/${VERSION}${VERSION_SUFFIX}
+git checkout helm-chart/${VERSION_RC}
rm -rf dist/*
```
4. Build the source tarball and package. Since you are not releasing the
package, you should ignore version
check and skip tagging. There is no need to specify version as it is stored
in Chart.yaml of the rc tag.
```shell
-breeze release-management prepare-helm-chart-tarball --version-suffix rc1
--ignore-version-check --skip-tagging
-breeze release-management prepare-helm-chart-package
+breeze release-management prepare-helm-chart-tarball --version-suffix
${VERSION_SUFFIX} --ignore-version-check --skip-tagging
+breeze release-management prepare-helm-chart-package --version-suffix
${VERSION_SUFFIX}
Review Comment:
This pop to my eyes as a change which I saw in other docs too using the
suffix to generate the files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]