o-nikolas commented on PR #61195: URL: https://github.com/apache/airflow/pull/61195#issuecomment-3830027317
> @jroachgolf84 do you know why it was deprecated? Imo we should allow users to configure `wait_policy` because not all of them may want to wait only till the cluster starts running. It gives them more flexibility to set the success criterion. It looks to me like there was a bit of confusion maybe before? There was an issue created [here](https://github.com/apache/airflow/issues/56153) that requested that `waiter_policy` be removed because: >The operator EmrCreateJobFlowOperator should follow the same standards as the other operator. All operators in Amazon provider package use the parameter wait_for_completion to configure whether the user wants to wait. However, in EmrCreateJobFlowOperator, this parameter is named wait_policy and is not a boolean but an enum. It looks to me like the `EmrCreateJobFlowOperator` used waiter_policy in addition to `wait_for_completion`. I quite like the pattern outlined in the Description here where `wait_for_completion` decides whether to wait and `waiter_policy` decides how to wait (but still inferring the former from the latter so that both don't need specifying). Tagging @vincbeck who created the original issue to remove `waiter_policy` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
