shahar1 commented on PR #61048: URL: https://github.com/apache/airflow/pull/61048#issuecomment-3830410709
> > If the parameter is not provided at all, raise the deprecation warning that this parameter will be set to default False in future release which will be a breaking change. > > Hi @shahar1, great proposal, thanks for digging up the precedent. One implementation detail: if we define it as `unwrap_single=True`, we can't distinguish "omitted" from "explicitly passed True", so we can't emit the deprecation warning only when the parameter is not provided. > > How about putting the deprecation warning under the `unwrap_single=True` block? You could let it to be optional (`None`), and if it's `None` (i.e., user has no set it explicitly) - then set it to True + raise a FutureWarning (there's another PR that implemented it, feel free to take inspiration) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
