shahar1 commented on code in PR #61334:
URL: https://github.com/apache/airflow/pull/61334#discussion_r2751850467
##########
providers/google/tests/unit/google/ads/operators/test_ads.py:
##########
@@ -21,7 +21,7 @@
from airflow.providers.google.ads.operators.ads import
GoogleAdsListAccountsOperator
CLIENT_IDS = ["1111111111", "2222222222"]
-BUCKET = "gs://test-google-ads-bucket"
Review Comment:
This doesn't seem directly related to this PR, I'd revert this for now.
##########
providers/google/src/airflow/providers/google/ads/transfers/ads_to_gcs.py:
##########
@@ -129,3 +134,6 @@ def execute(self, context: Context) -> None:
gzip=self.gzip,
)
self.log.info("%s uploaded to GCS", self.obj)
+
+ gcs_uri = f"gs://{self.bucket}/{self.obj}"
Review Comment:
Please read my comment in the main issue regarding backward-compatiblity and
the introduction of `unwrap_single` flag (also take a look in other PRs that
implemented it).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
