uranusjr commented on code in PR #61251:
URL: https://github.com/apache/airflow/pull/61251#discussion_r2752368729


##########
airflow-core/src/airflow/api_fastapi/execution_api/app.py:
##########
@@ -278,6 +279,11 @@ def get_extra_schemas() -> dict[str, dict]:
         "TaskInstanceState": {"type": "string", "enum": 
list(TaskInstanceState)},
         "WeightRule": {"type": "string", "enum": list(WeightRule)},
         "TriggerRule": {"type": "string", "enum": list(TriggerRule)},
+        "DagAttributeTypes": {
+            "type": "string",
+            "enum": [DagAttributeTypes.OP.value, 
DagAttributeTypes.TASK_GROUP.value],
+            "x-enum-varnames": [DagAttributeTypes.OP.name, 
DagAttributeTypes.TASK_GROUP.name],

Review Comment:
   Can these be dynamic? e.g. `[m.name for m in DagAttributeTypes.__members__]`



##########
airflow-core/src/airflow/api_fastapi/execution_api/app.py:
##########
@@ -278,6 +279,11 @@ def get_extra_schemas() -> dict[str, dict]:
         "TaskInstanceState": {"type": "string", "enum": 
list(TaskInstanceState)},
         "WeightRule": {"type": "string", "enum": list(WeightRule)},
         "TriggerRule": {"type": "string", "enum": list(TriggerRule)},
+        "DagAttributeTypes": {
+            "type": "string",
+            "enum": [DagAttributeTypes.OP.value, 
DagAttributeTypes.TASK_GROUP.value],
+            "x-enum-varnames": [DagAttributeTypes.OP.name, 
DagAttributeTypes.TASK_GROUP.name],

Review Comment:
   Can these be dynamic? e.g. `[m.name for m in DagAttributeTypes]`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to