shahar1 commented on PR #61262: URL: https://github.com/apache/airflow/pull/61262#issuecomment-3834019334
> > CI seems to fail now :( Please let me know if you need some guidance. > > @shahar1, > > thanks for the review and the offer to help > > CI is still failing across multiple provider/distribution jobs. Before making further changes, could you please point me to which specific assertion or behavior in the GenAI operator tests is incompatible with current expectations, or which check you’d recommend I focus on first? > > CI seems to fail now :( Please let me know if you need some guidance. > > @shahar1, thanks for the review and the offer to help CI is still failing across multiple provider/distribution jobs. Before making further changes, could you please point me to which specific assertion or behavior in the GenAI operator tests is incompatible with current expectations, or which check you’d recommend I focus on first? Hey, I'd like to let you know that I've made a mistake and the tests which I thought were missing, actually exist in this file: https://github.com/apache/airflow/blob/af12a42a48e99493be244e0355f8ffa222e28122/providers/google/tests/unit/google/cloud/operators/test_gen_ai.py#L142 I also overlooked that the test file you proposed was in the wrong path (it should be in `providers/google/test/unit/google`)) which partially caused this confusion when reviewing this PR. However, you may still use this PR to try and test the exceptions raised in the current source file and currently not tested, for example: https://github.com/VladaZakharova/airflow/blob/bb04b5d69ab7fd1b410652d70b84c8607abc52f0/providers/google/src/airflow/providers/google/cloud/operators/gen_ai.py#L479 Try to look at the current test file, as well as others - and then you could try to utilize this PR for working on the exceptions. My sincere apologies for the mess, I'll convert this PR to draft for now. If you plan to reuse it for testing the exceptions, please comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
