jscheffl commented on code in PR #56456: URL: https://github.com/apache/airflow/pull/56456#discussion_r2755635031
########## providers/edge3/hatch_build.py: ########## @@ -0,0 +1,118 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review Comment: Can we make this in a follow-up PR when we see a benefit applying this to Fab/Keycloak? This is now only 69 lines left and ~10 lines are provider specific. I assume overhead in generation is higher than keeping the copies (as each provider has some different path's where stuff is sitting... would need to be parameterized and templated... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
