SameerMesiah97 commented on PR #61110:
URL: https://github.com/apache/airflow/pull/61110#issuecomment-3837302018
@Nataneljpwd
I rest my case. I am not fully convinced that there cannot be multiple pods
returned in your new implementation for `find_spark_job` but I will no longer
block this PR based on the 2 concerns I communicated.
I appreciate all the thought and effort you put into this but whilst going
through the diff, I did see quite a few areas in need of refinement. I have
made comments where I saw specific areas which could be improved but I think it
would not hurt to review the new implementation for `find_spark_job` and the
relevant tests to make sure that tests are explicit, correctly documented and
that they adequately guard against regressions. Once these gaps are addressed,
I am okay with this PR being merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
