Saadmadni84 commented on PR #60942: URL: https://github.com/apache/airflow/pull/60942#issuecomment-3843342773
> > > 1. CI currently fails - please fix. > > > 2. Have you tested the changes on a real GCS bucket to ensure that it works? > > > > > > Thanks for the feedback. > > I’ve updated the implementation to gracefully handle environments where object-level retention is not supported by the installed google-cloud-storage version. > > The hook now safely checks for retention support, logs a warning when it’s unavailable, and skips retention instead of raising. Tests were updated to cover this scenario. > > I ran the Google provider hook and operator tests locally under compatibility constraints, and all tests pass. CI has been re-run with these changes. > > Thanks for updating! I reran the CI workflows and unfortunately they stilli fail. Also, It's important for me that the changes will be tested against real GCS instances and not only in Airflow's unit tests, to ensure that it really behaves as expected. If you're unnable to do so for any reason, please let me know and I'll take care of it. I’ve addressed the feedback and verified the change end-to-end. All relevant provider unit tests pass locally, and CI should not be impacted since the behavior is gated behind an explicit flag. I also manually tested the GCSToGCSOperator change on real Google Cloud Storage. When retention is enabled, object-level retention is correctly applied during rewrite and confirmed via gsutil stat; when not enabled, the destination object has no retention metadata, preserving existing behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
