pierrejeambrun commented on code in PR #58881: URL: https://github.com/apache/airflow/pull/58881#discussion_r2764816780
########## airflow-core/src/airflow/ui/src/hooks/useTabMemory.ts: ########## Review Comment: I'm not found of this component. Doing comparison and hard redirect between renders we see a flickering. Instead during navigation, before landing on the page, for instance before going to the 'TI' page with a default tab active and then flickering to a redirect for the persisted local storage. Can't we compute directly the correct final route before redirection (taking into account the persisted value in the storage), and then directly land on the appropriate page, removing that intermediate redirect. This will prevent the flickering effect that is not great for UX, and also will prevent unnecessary request to be fired from the intermediate page that we actually do not need. (since we are directly being redirected to the storage persisted tab) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
