Prab-27 commented on code in PR #61349:
URL: https://github.com/apache/airflow/pull/61349#discussion_r2765039038
##########
providers/google/src/airflow/providers/google/cloud/transfers/facebook_ads_to_gcs.py:
##########
@@ -122,11 +122,21 @@ def __init__(
self.upload_as_account = upload_as_account
self.impersonation_chain = impersonation_chain
- def execute(self, context: Context):
+ def execute(self, context: Context) -> list[str]:
+ """
+ Execute the operator.
+
+ Fetches Facebook Ads reports and uploads them to Google Cloud Storage.
+
+ :return: List of GCS URIs where the reports were uploaded.
+ This value is pushed to XCom for downstream tasks.
+ :rtype: List[str]
Review Comment:
It seems `:rtype: List[str]` indicate the return type of the method .
Generally, we don’t mention the return type in the method (description -
comment) since it’s already specified in the function definition
Could you please share your thoughts on this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
