vincbeck commented on PR #61351: URL: https://github.com/apache/airflow/pull/61351#issuecomment-3849905060
> Thanks for the PR @stegololz! Looks good! I cannot see [c6eb21e](https://github.com/apache/airflow/commit/c6eb21e00bcc891db3ba04271779388a9f4d667a) in the PR that you mentioned includes CLI changes. Are you planning to create another PR for CLI? I would suggest to please include into this PR so there would be a clear connectionwith the current implementation, as I see `+7 -2` only, which is not high. Could you please also check the tests? It fails for permission in Python 3.10 and in some others https://github.com/apache/airflow/actions/runs/21682494606/job/62540136484?pr=61351 I would still like to get @o-nikolas's and @vincbeck's take on the multi-team approach, when you have time Hey Bugra, thanks for the review. We agreed with @stegololz to split the PR in 2 PRs, one for CLI and one for the auth manager implementation. It makes it easier to review it :) You can find the PR related to CLI here: https://github.com/apache/airflow/pull/61256 but overall you can track the overall effort in this issue: #60885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
