MonsterChenzhuo commented on code in PR #61374:
URL: https://github.com/apache/airflow/pull/61374#discussion_r2766765063
##########
providers/fab/src/airflow/providers/fab/auth_manager/security_manager/override.py:
##########
@@ -1457,11 +1457,19 @@ def find_user(self, username=None, email=None) -> User
| None:
).one_or_none()
except MultipleResultsFound:
log.error("Multiple results found for user %s", username)
+ except Exception as e:
+ log.error("Error finding user %s: %s", username, e)
+ self.get_session.rollback()
+ return None
elif email:
try:
return
self.session.scalars(select(self.user_model).filter_by(email=email)).one_or_none()
except MultipleResultsFound:
log.error("Multiple results found for user with email %s",
email)
+ except Exception as e:
+ log.error("Error finding user with email %s: %s", email, e)
+ self.get_session.rollback()
Review Comment:
done.
##########
providers/fab/src/airflow/providers/fab/auth_manager/security_manager/override.py:
##########
@@ -1457,11 +1457,19 @@ def find_user(self, username=None, email=None) -> User
| None:
).one_or_none()
except MultipleResultsFound:
log.error("Multiple results found for user %s", username)
+ except Exception as e:
+ log.error("Error finding user %s: %s", username, e)
+ self.get_session.rollback()
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
