Lee-W commented on code in PR #61439:
URL: https://github.com/apache/airflow/pull/61439#discussion_r2769368316
##########
providers/hashicorp/src/airflow/providers/hashicorp/hooks/vault.py:
##########
@@ -89,6 +90,10 @@ class VaultHook(BaseHook):
:param kubernetes_role: Role for Authentication (for ``kubernetes``
auth_type)
:param kubernetes_jwt_path: Path for kubernetes jwt token (for
``kubernetes`` auth_type, default:
``/var/run/secrets/kubernetes.io/serviceaccount/token``)
+ :param jwt_role: Role for Authentication (for ``jwt`` auth_type)
Review Comment:
the doc string also should reflect the arg order
##########
providers/hashicorp/src/airflow/providers/hashicorp/_internal_client/vault_client.py:
##########
@@ -121,6 +127,9 @@ def __init__(
radius_host: str | None = None,
radius_secret: str | None = None,
radius_port: int | None = None,
+ jwt_role: str | None = None,
Review Comment:
```suggestion
*,
jwt_role: str | None = None,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
