vincbeck commented on code in PR #61491:
URL: https://github.com/apache/airflow/pull/61491#discussion_r2769863475
##########
airflow-core/src/airflow/migrations/versions/0033_3_0_0_add_tables_for_backfill.py:
##########
@@ -49,7 +48,7 @@ def upgrade():
sa.Column("dag_id", sa.String(length=250), nullable=False),
sa.Column("from_date",
airflow.utils.sqlalchemy.UtcDateTime(timezone=True), nullable=False),
sa.Column("to_date",
airflow.utils.sqlalchemy.UtcDateTime(timezone=True), nullable=False),
- sa.Column("dag_run_conf", sqlalchemy_jsonfield.jsonfield.JSONField(),
nullable=False),
Review Comment:
You still modify the data type in the DB right? That's a DB change.
> If we don't modify this, how can we eliminate the import?
The same way as you do it right, nothing change. Instead of updating all the
migrations you create a new one that modifies all these tables, but codewise,
nothings change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
