amoghrajesh opened a new pull request, #61523: URL: https://github.com/apache/airflow/pull/61523
<!-- Thank you for contributing! Please provide above a brief description of the changes made in this pull request. Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/ Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping (in general) for the review if you do not see reaction for a few days (72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications. In case of an existing issue, reference it using one of the following: * closes: #ISSUE * related: #ISSUE --> --- ##### Was generative AI tooling used to co-author this PR? <!-- If generative AI tooling has been used in the process of authoring this PR, please change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by". --> - [x] No <!-- Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) --> ### Why? The shared `BaseSecretsBackend` was importing Connection classes from airflow-core or airflow-sdk conditionally based on the current process context, creating a dependency that breaks client-server separation in ways. This change removes that dependency by injecting the Connection class per instance at distribution init time. Both core and sdk have backend loaders: `initialize_secrets_backends` which now set the Connection class on each backend instance via `_set_connection_class()` when instantiating their backends. This ensures each backend uses the correct Connection type (core or sdk) based on where it's created, without the shared base needing to know about either. The shared base now has zero imports of core or SDK Connection types, maintaining proper separation between components. ### Design Decision and Alternatives #### Why per instance instead of class level default? I considered a class level `_default_connection_class` attribute, but didn't choose it because: 1. Core imports would overwrite task-sdk defaults when loading backends or vice versa 2. In processes importing both core and task-sdk, whichever set the default last would win, regardless of context 3. All backend instances would share one default state which was mutable, causing interference between backends Per instance storage avoids all these issues by making each backend independent. #### Why not use a factory/callable? I also considered storing a callable that returns the Connection class, but chose direct class storage over that one cos: - Simpler implementation - Same robustness with less complexity ### Back compat - No changes to public API - Existing backend code continues to work - Wherever the backend are created, they are initialised at runtime via Backends created via `initialize_secrets_backends`. So, they automatically get the correct Connection class set on the instances. --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
