Nataneljpwd commented on code in PR #61528:
URL: https://github.com/apache/airflow/pull/61528#discussion_r2774599030
##########
providers/apache/spark/tests/unit/apache/spark/hooks/test_spark_submit.py:
##########
@@ -532,6 +563,31 @@ def
test_resolve_connection_spark_binary_spark3_submit_set_connection(self):
assert connection == expected_spark_connection
assert cmd[0] == "spark3-submit"
+ def test_resolve_connection_spark_uri_with_protocol(self):
+ hook = SparkSubmitHook(conn_id="spark_uri_with_protocol")
+ connection = hook._resolve_connection()
+ assert connection["master"] == "spark://spark-master:7077"
Review Comment:
Why did you only test the connection master? Why not the whole connection?
Are these tests even necessary? I see it already tested above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
