o-nikolas commented on code in PR #61498:
URL: https://github.com/apache/airflow/pull/61498#discussion_r2775910569
##########
providers/amazon/src/airflow/providers/amazon/aws/hooks/sagemaker_unified_studio.py:
##########
@@ -40,24 +40,43 @@ class SageMakerNotebookHook(BaseHook):
from airflow.providers.amazon.aws.hooks.sagemaker_unified_studio
import SageMakerNotebookHook
notebook_hook = SageMakerNotebookHook(
+ execution_name="notebook_execution",
+ domain_id="dzd-example123456",
+ project_id="example123456",
input_config={"input_path": "path/to/notebook.ipynb",
"input_params": {"param1": "value1"}},
output_config={"output_uri": "folder/output/location/prefix",
"output_formats": "NOTEBOOK"},
- execution_name="notebook_execution",
+ domain_region="us-east-1",
waiter_delay=10,
waiter_max_attempts=1440,
)
:param execution_name: The name of the notebook job to be executed, this
is same as task_id.
+ :param domain_id: The domain ID for Amazon SageMaker Unified Studio.
Optional - if not provided,
+ the SDK will attempt to resolve it from the MWAA environment.
Review Comment:
It is technically possible to export the right variables in a non-MWAA env,
no?
```suggestion
the SDK will attempt to resolve it from the environment.
```
Same suggestion for below and in the operator module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
