darrenleeweber edited a comment on issue #6764: [AIRFLOW-6206] Use "aws_" prefix for aws_batch_operator.py module URL: https://github.com/apache/airflow/pull/6764#issuecomment-563851879 @mik-laj - With respect, adding those requirements onto this PR seems out of place. This PR is really only about renaming the module, the additional requirements for AIP-21 seem to belong elsewhere with a larger migration of many contribution modules? It seems out of place to do that migration just for this one module in this PR. AFAICT, the use of this module might not be changed because the import patterns might not refer directly to the full package path for this module, but get it via higher level packaging (or wrapping) and that is not changed here in this PR. If it is a breaking change, then it should be so because the naming pattern should be consistent across all the AWS providers (contrib modules). Since the batch operator is not already in the https://github.com/apache/airflow/blob/master/tests/test_core_to_contrib.py, it was not found with a git-grep. It might be an oversight that it's not there already, or an intentional omission. Is there a clear answer as to why it is not already there? If it's a simple omission and it's easy to add a two-line mapping, I guess it could be added here in this PR. FYI, compare the outputs from ``` git grep 'AWSBatchOperator' git grep 'AWSAthenaOperator' ``` You will see that the `AWSBatchOperator` is not already in the `airflow/providers/amazon/aws/operators/` package and so adding it to that test fails the test. Based on that, I conclude that it's an intention omission from that test.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
