justinpakzad opened a new pull request, #61595: URL: https://github.com/apache/airflow/pull/61595
<!-- Thank you for contributing! Please provide above a brief description of the changes made in this pull request. Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/ Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping (in general) for the review if you do not see reaction for a few days (72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications. In case of an existing issue, reference it using one of the following: * closes: #ISSUE * related: #ISSUE --> related: #61166 Opened this PR to implement a way to list variable keys (optionally by prefix) via the task SDK. The ask in the issue was to support fetching variables where the keys might not be known beforehand. I've implemented a `list_keys()` method in the Variable class with an optional prefix parameter. Example: `Variable.list_keys(prefix="api_")` There were some architectural decisions I was unsure about. For example, whether a method like `list_keys()` should be part of the Variable class or if it should live elsewhere, given that variable represents a single k/v pair. Also, the existing router dependency expects a key as a path parameter, but that wouldn't work here, meaning I needed to move that to the function level and exclude it from the list keys endpoint. Lastly, there could be a path conflict with the existing `/{variable_key:path}` route. For now I just used `/keys/list`, but that's probably not ideal (maybe a separate router?). Anyways, opening this up for a discussion. --- ##### Was generative AI tooling used to co-author this PR? <!-- If generative AI tooling has been used in the process of authoring this PR, please change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by". --> - [x] Yes (please specify the tool below) Generated-by: [Claude Sonnet 4.5] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
