mik-laj commented on issue #6764: [AIRFLOW-6206] Use "aws_" prefix for aws_batch_operator.py module URL: https://github.com/apache/airflow/pull/6764#issuecomment-563936011 This is not just a module change, but your implementation is not backwards compatible, which can cause a problem for users who use this class. This code will start throwing an exception if your change is accepted. ``` from airflow.contrib.operators.awsbatch_operator import AWSBatchOperator ``` Instead, it should display a deprecation message and work correctly in subsequent versions. https://github.com/apache/airflow/pull/6455/files https://github.com/apache/airflow/pull/6454/files In the file https://github.com/apache/airflow/blob/master/tests/test_core_to_contrib.py we have tests that check whether previous import paths still work after moving the class to a new location. Your service has not been adapted to AIP-21, so it has not been added yet, but if you are moving files then you should move the files to a good place. The file cannot be moved to the wrong/temporary place, because migration requires the user's intervention and will be very confused if in each version he will have to change the import path. Can you move also change location of tets? https://github.com/apache/airflow/blob/master/tests/contrib/operators/test_awsbatch_operator.py
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
