jscheffl commented on code in PR #61646:
URL: https://github.com/apache/airflow/pull/61646#discussion_r2779677938
##########
providers/edge3/src/airflow/providers/edge3/executors/edge_executor.py:
##########
@@ -187,6 +206,11 @@ def _check_worker_liveness(self, session: Session) -> bool:
).all()
for worker in lifeless_workers:
+ # In multi-team setups, only manage workers whose queues overlap
with ours.
+ # EdgeWorkerModel.queues is stored as a stringified list so SQL
filtering is not feasible.
+ if self._managed_queues and worker.queues:
+ if not set(worker.queues) & self._managed_queues:
+ continue
Review Comment:
No, I object here. Dead workers are dead workers, irrespective to which team
they belong. Does not make sense from operational perspective to make team
specific configurations for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
