potiuk commented on code in PR #61662:
URL: https://github.com/apache/airflow/pull/61662#discussion_r2781570608
##########
providers/http/src/airflow/providers/http/operators/http.py:
##########
@@ -286,7 +286,15 @@ def execute_complete(
Relies on trigger to throw an exception, otherwise it assumes
execution was successful.
"""
if event["status"] == "success":
- response =
pickle.loads(base64.standard_b64decode(event["response"]))
+ try:
+ response =
HttpResponseSerializer.deserialize(event["response"])
+ except TypeError:
+ # old pickle format detected - handle it but issue a
deprecation warning
+ self.log.warning(
Review Comment:
I think we should not handle it, it does not remove the possibility of
deserializing arbitrary value. I think we should add a changelog entry
specifying that all Dags using deferrable HTTP request should be paused and
completed before upgrading to this provider version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
