v4xsh commented on PR #61556:
URL: https://github.com/apache/airflow/pull/61556#issuecomment-3870885209
Thanks for the follow-up @guan404ming — I walked through the full flow
end-to-end to verify this.
The conditional you suggested (`delete param only when value ===
defaultShowPaused`) is part of the solution, but on its own it isn’t
sufficient. The key issue is that downstream we currently treat:
* `paused=all`
* and an absent `paused` param
the same **unless we explicitly handle the default in `DagsList.tsx`**.
With `hide_paused_dags_by_default=true`, simply deleting the param causes
the backend to apply the default (`paused=false`), which makes an explicit
“All” selection collapse back into the default state. The additional logic in
`DagsList.tsx` is what ensures defaults are applied **only when no filter is
selected**, and that explicit user intent always takes precedence.
I verified that without this handling, the issue still reproduces even if
the param deletion is done conditionally. With the current changes, “All”
remains actionable and consistently shows both paused and unpaused DAGs.
Based on my understanding of the current flow, I don’t think this can be
reduced to just a single-line change without bringing the issue back, but I’m
definitely open to simplifying it further if you see a clearer way to achieve
the same behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
