shahar1 commented on code in PR #61546:
URL: https://github.com/apache/airflow/pull/61546#discussion_r2784115901
##########
providers/google/tests/unit/google/cloud/hooks/test_cloud_run.py:
##########
@@ -264,16 +264,31 @@ def test_delete_job(self, mock_batch_service_client,
cloud_run_hook):
new=mock_base_gcp_hook_default_project_id,
)
@mock.patch("airflow.providers.google.cloud.hooks.cloud_run.JobsClient")
- @pytest.mark.parametrize(("transport", "expected_transport"), [("rest",
"rest"), (None, None)])
- def test_get_conn_with_transport(self, mock_jobs_client, transport,
expected_transport):
+ @pytest.mark.parametrize("transport", ["rest"])
Review Comment:
for the unit test - maybe a `None` to test the other case of the `if`
statement. I'll handle it before merging (GitHub is currently stuck)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
