shahar1 commented on PR #61306:
URL: https://github.com/apache/airflow/pull/61306#issuecomment-3875776299
> Thanks for your review comments @uranusjr and @shahar1 ! Had made changes,
assuming both True and False cases should be handled for unwrap_single field,
for current state, to ensure failsafe for future. Since we are planning to
remove it in long run, does not make sense to do that anymore.
>
> Since am not aware of the past context, I was curious to learn the reason
behind "unwrap_single" name has been chosen for this interim parameter name.
If you've made any changes, you might have forgotten to push them :)
Basically it was my idea for the naming - I took inspiration from
`KubernetesPodOperator` that has the same parameter. As the name hints, it
"unwraps" lists of single entities (e.g, `['gs://bucket/file']`) into a string
(`'gs://bucket/file'`). It's good for backward-compatibility for the cases that
already return the single entity as default, but I think that for the long term
it's better that all operators will return `list[str]`, and the user will take
care of the unwrapping if necessary (i.e., `lst[0]` for single entities).
In the case of `HttpToGCSOperator`, it doesn't return anything at the moment
- so it's just a matter of `return
[f"gs://{self.bucket_name}/{self.object_name}"]`, and that's all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
