ashb commented on a change in pull request #6230: [AIRFLOW-5413] Allow K8S
worker pod to be configured from JSON/YAML file
URL: https://github.com/apache/airflow/pull/6230#discussion_r356001522
##########
File path: airflow/executors/kubernetes_executor.py
##########
@@ -372,7 +374,8 @@ def __init__(self,
self.log.debug("Kubernetes using namespace %s", self.namespace)
self.kube_client = kube_client
self.launcher = PodLauncher(kube_client=self.kube_client)
- self.worker_configuration =
WorkerConfiguration(kube_config=self.kube_config)
+ # Parse the airflow.cfg once on AirflowKubernetesScheduler
initialization
+ self.worker_configuration =
WorkerConfiguration(kube_config=self.kube_config).make_pod()
Review comment:
This is variable is now somewhat confusingly named -- it's no longer a
WorkerConfiguration but a v1.Pod object.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
