potiuk commented on code in PR #61727:
URL: https://github.com/apache/airflow/pull/61727#discussion_r2787937454
##########
dev/breeze/src/airflow_breeze/commands/release_candidate_command.py:
##########
@@ -678,16 +675,11 @@ def remove_old_releases(version, task_sdk_version,
repo_root):
for old_release in old_releases:
console_print(f"Removing old Airflow release {old_release}")
if confirm_action(f"Remove old RC {old_release}?"):
- if is_ci_environment():
- console_print("[info]Running in CI environment - simulating
SVN rm and commit")
- console_print(f"[info]Would run: svn rm {old_release}")
- console_print(f"[info]Would run: svn commit -m 'Remove old
release: {old_release}'")
- else:
- run_command(["svn", "rm", old_release], check=True)
- run_command(
- ["svn", "commit", "-m", f"Remove old release:
{old_release}"],
- check=True,
- )
+ run_command(["svn", "rm", old_release], check=True)
Review Comment:
Same here. `--dry-run` does not actually run `run_command` command - it just
displays what would have happened.
##########
dev/breeze/src/airflow_breeze/commands/release_candidate_command.py:
##########
@@ -705,18 +697,11 @@ def remove_old_releases(version, task_sdk_version,
repo_root):
for old_release in old_task_sdk_releases:
console_print(f"Removing old Task SDK release {old_release}")
if confirm_action(f"Remove old Task SDK RC {old_release}?"):
- if is_ci_environment():
- console_print("[info]Running in CI environment -
simulating SVN rm and commit")
- console_print(f"[info]Would run: svn rm {old_release}")
- console_print(
- f"[info]Would run: svn commit -m 'Remove old Task SDK
release: {old_release}'"
- )
- else:
- run_command(["svn", "rm", old_release], check=True)
- run_command(
- ["svn", "commit", "-m", f"Remove old Task SDK release:
{old_release}"],
- check=True,
- )
+ run_command(["svn", "rm", old_release], check=True)
Review Comment:
same here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
