jason810496 commented on code in PR #61713:
URL: https://github.com/apache/airflow/pull/61713#discussion_r2789206310
##########
providers/standard/src/airflow/providers/standard/operators/bash.py:
##########
@@ -34,8 +34,7 @@
if TYPE_CHECKING:
from airflow.providers.common.compat.sdk import Context
-
- from tests_common.test_utils.version_compat import ArgNotSet
Review Comment:
> it could be potentially prone to future misuse
Yes, I agree with that. I will vote for not using test modules even under
`TYPE_CHECKING` to avoid future misuse. Additionally, if we really need those
type annotation, it would be better to place under version compat module or
just having small part of duplication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
