SameerMesiah97 commented on code in PR #61738:
URL: https://github.com/apache/airflow/pull/61738#discussion_r2789253791
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/hooks/kubernetes.py:
##########
@@ -886,15 +887,15 @@ async def _load_config(self):
client_configuration=self.client_configuration,
context=cluster_context,
)
- self._config_loaded = True
+
return
self.log.debug(LOADING_KUBE_CONFIG_FILE_RESOURCE.format("default
configuration file"))
await async_config.load_kube_config(
client_configuration=self.client_configuration,
context=cluster_context,
)
- self._config_loaded = True
Review Comment:
This flag was added by me in PR #60532 to avoid polluting the logs when
using `def watch_pod_events`. Removing them should fix issue #61738 but it will
degrade observability. As your fix addresses a reported bug, this takes
precedence over that but I think your approach which entails always fetching
the config is a bit too blunt. I think an expiry aware approach as hinted at in
issue #61738 would be the better solution in the long-run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
