Eason09053360 opened a new pull request, #61760: URL: https://github.com/apache/airflow/pull/61760
# Fix ASYNC110 violation in TriggerRunner main loop Replaces the `while + sleep` polling pattern in `TriggerRunner.arun()` with event-driven shutdown using `anyio.Event`. This eliminates the ASYNC110 linting violation and improves shutdown responsiveness. ## Why is this change needed? The previous implementation used `await asyncio.sleep(1)` in a while loop, which is flagged by the ASYNC110 rule as an anti-pattern. This polling approach: - Wastes CPU cycles checking conditions repeatedly - Has a 1-second delay when stopping the triggerer ## What does this PR do? - Adds `anyio.Event` for signaling stop condition - Uses `anyio.move_on_after(1)` instead of `asyncio.sleep(1)` - Signals the event in `_handle_signal()` for immediate shutdown - Maintains the 1-second periodic execution for normal operation --- ##### Was generative AI tooling used to co-author this PR? <!-- If generative AI tooling has been used in the process of authoring this PR, please change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by". --> - [ ] Yes (please specify the tool below) <!-- Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) --> --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
