darrenleeweber commented on a change in pull request #6455: [WIP][AIRFLOW-5777] Migrate AWS DynamoDB to /providers/aws [AIP-21] URL: https://github.com/apache/airflow/pull/6455#discussion_r356166421
########## File path: airflow/providers/aws/operators/dynamodb.py ########## @@ -0,0 +1,226 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import json +from copy import copy +from os.path import getsize +from tempfile import NamedTemporaryFile +from typing import Any, Callable, Dict, Optional +from uuid import uuid4 + +from airflow.hooks.hive_hooks import HiveServer2Hook +from airflow.hooks.S3_hook import S3Hook +from airflow.models import BaseOperator +from airflow.providers.aws.hooks.dynamodb import AwsDynamoDBHook +from airflow.utils.decorators import apply_defaults Review comment: Should this import from the new package path instead? i.e. - `from airflow.providers.aws.hooks import S3Hook` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
