dabla commented on PR #60458: URL: https://github.com/apache/airflow/pull/60458#issuecomment-3883051528
> > @eladkal Question, in the livy `provider.yaml` I saw that the `asgiref` dependency is specified, but the common-compat provider on which is depends on also has that dependency, so I would think it can be removed from the livy one as it will be a transient dependency anyway, correct? > > ``` > > dependencies = [ > > "apache-airflow>=2.11.0", > > "apache-airflow-providers-http>=5.1.0", # use next version > > "apache-airflow-providers-common-compat>=1.12.0", > > "aiohttp>=3.9.2", > > "asgiref>=2.3.0", # TODO: I think this one can be removed? Already present in apache-airflow-providers-common-compat > > ] > > ``` > > If `asgiref` is direct dependency of the provider it should stay. You can not guarantee that another provider will keep his dependencies as it is today so you always must specify all the dependencies you must have. If `asgiref` was added to solve some upstream issue temporarily then it can be removed. Asgiref is not directly used within the Livy provider, it was in the past to be able to call the `get_connection` in an async way, but now this have be refacored as a re-useable `get_async_connection` method in common-compat, I also think most if not all providers have already been updated to use that method instead of redefining it each time within the provider, so I think we can remove it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
