bbovenzi commented on code in PR #53216:
URL: https://github.com/apache/airflow/pull/53216#discussion_r2794606530
##########
airflow-core/src/airflow/ui/src/layouts/Details/Grid/TaskInstancesColumn.tsx:
##########
@@ -32,25 +35,47 @@ type Props = {
readonly nodes: Array<GridTask>;
readonly onCellClick?: () => void;
readonly run: GridRunsResponse;
+ readonly showVersionIndicatorMode?: VersionIndicatorDisplayOptions;
readonly virtualItems?: Array<VirtualItem>;
};
const ROW_HEIGHT = 20;
-export const TaskInstancesColumn = ({ nodes, onCellClick, run, virtualItems }:
Props) => {
+export const TaskInstancesColumn = ({
+ nodes,
+ onCellClick,
+ run,
+ showVersionIndicatorMode,
+ virtualItems,
+}: Props) => {
const { dagId = "", runId } = useParams();
const { data: gridTISummaries } = useGridTiSummaries({ dagId, runId:
run.run_id, state: run.state });
const { hoveredRunId, setHoveredRunId } = useHover();
const itemsToRender =
virtualItems ?? nodes.map((_, index) => ({ index, size: ROW_HEIGHT, start:
index * ROW_HEIGHT }));
- const taskInstances = gridTISummaries?.task_instances ?? [];
- const taskInstanceMap = new Map<string, LightGridTaskInstanceSummary>();
+ const taskInstances = useMemo(
+ () => gridTISummaries?.task_instances ?? [],
+ [gridTISummaries?.task_instances],
+ );
+ const taskInstanceMap = useMemo(() => {
+ const map = new Map<string, LightGridTaskInstanceSummary>();
+
+ for (const ti of taskInstances) {
+ map.set(ti.task_id, ti);
+ }
+
+ return map;
+ }, [taskInstances]);
Review Comment:
Correct. Let's remove them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
