andreahlert commented on code in PR #61629:
URL: https://github.com/apache/airflow/pull/61629#discussion_r2795364792
##########
providers/standard/src/airflow/providers/standard/operators/python.py:
##########
@@ -637,6 +637,20 @@ def _execute_python_callable_in_subprocess(self,
python_path: Path):
env_vars = dict(os.environ) if self.inherit_env else {}
if fd := os.getenv("__AIRFLOW_SUPERVISOR_FD"):
env_vars["__AIRFLOW_SUPERVISOR_FD"] = fd
+ elif AIRFLOW_V_3_0_PLUS and "__AIRFLOW_SUPERVISOR_FD" not in
env_vars:
Review Comment:
You're right. I traced the Popen call and stdin isn't redirected, so fd 0 is
inherited as-is. reinit_supervisor_comms already defaults to fd 0 when the env
var is missing, so this whole block is redundant.
Dropping it in v2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
