potiuk edited a comment on issue #6760: [AIRFLOW-6157] Separate out common protocol for executors. URL: https://github.com/apache/airflow/pull/6760#issuecomment-564182397 > The changes make sense, but just not the addition of the extra "Protocol" base class. It had much more sense when I implemented Multiple Executor. Simply because I have not used any of the logic implemented in BaseExecutor - the implementations of multiple executor were merely iterating over the several executors or found the one that they should use by queue name - and then the whole logic implemented in the - de facto - BaseExecutor mixin was not needed. But I agree since we are not adding multiple executor it might make sense to keep BaseExecutor as Mixin and simply use it everywhere rather than separate out the Protocol. It's a bit Java'is approach (Interface) which creeped in. I will refactor it.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
