potiuk commented on a change in pull request #6760: [AIRFLOW-6157] Separate out 
common protocol for executors.
URL: https://github.com/apache/airflow/pull/6760#discussion_r356220845
 
 

 ##########
 File path: airflow/executors/base_executor.py
 ##########
 @@ -52,26 +170,30 @@ class BaseExecutor(LoggingMixin):
     """
     def __init__(self, parallelism: int = PARALLELISM):
         super().__init__()
-        self.parallelism: int = parallelism
-        self.queued_tasks: OrderedDict[TaskInstanceKeyType, 
QueuedTaskInstanceType] \
-            = OrderedDict()
-        self.running: Set[TaskInstanceKeyType] = set()
-        self.event_buffer: Dict[TaskInstanceKeyType, Optional[str]] = {}
+        self._parallelism: int = parallelism
 
 Review comment:
   Just to not access it directly (encapsulation). But true. Since it's python 
and it's a number, I can leave it as it is. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to