vatsrahul1001 commented on code in PR #60738: URL: https://github.com/apache/airflow/pull/60738#discussion_r2796756530
########## airflow-core/src/airflow/ui/tests/e2e/pages/ConnectionsPage.ts: ########## @@ -0,0 +1,622 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { expect, type Locator, type Page } from "@playwright/test"; +import { BasePage } from "tests/e2e/pages/BasePage"; + +type ConnectionDetails = { + conn_type: string; + connection_id: string; + description?: string; + extra?: string; + host?: string; + login?: string; + password?: string; + port?: number | string; + schema?: string; +}; + +export class ConnectionsPage extends BasePage { + // Page URLs + public static get connectionsListUrl(): string { + return "/connections"; + } + + public readonly addButton: Locator; + public readonly confirmDeleteButton: Locator; + public readonly connectionForm: Locator; + public readonly connectionIdHeader: Locator; + public readonly connectionIdInput: Locator; + // Core page elements + public readonly connectionsTable: Locator; + public readonly connectionTypeHeader: Locator; + public readonly connectionTypeSelect: Locator; + public readonly descriptionInput: Locator; + public readonly emptyState: Locator; + public readonly hostHeader: Locator; + public readonly hostInput: Locator; + public readonly loginInput: Locator; + + // Pagination elements + public readonly paginationNextButton: Locator; + public readonly paginationPrevButton: Locator; + public readonly passwordInput: Locator; + + public readonly portInput: Locator; + public readonly rowsPerPageSelect: Locator; + public readonly saveButton: Locator; + + public readonly schemaInput: Locator; + public readonly searchInput: Locator; + public readonly successAlert: Locator; + // Sorting and filtering + public readonly tableHeader: Locator; + public readonly testConnectionButton: Locator; + + public constructor(page: Page) { + super(page); + // Table elements (Chakra UI DataTable) + this.connectionsTable = page.locator('[role="grid"], table'); + this.emptyState = page.locator("text=/No connection found!/i"); + + // Action buttons + this.addButton = page.getByRole("button", { name: "Add Connection" }); + this.testConnectionButton = page.locator('button:has-text("Test")'); + this.saveButton = page.getByRole("button", { name: /^save$/i }); + + // Form inputs (Chakra UI inputs) + this.connectionForm = page.locator('[data-scope="dialog"][data-part="content"]'); + this.connectionIdInput = page.locator('input[name="connection_id"]').first(); + this.connectionTypeSelect = page.getByRole("combobox").first(); + this.hostInput = page.locator('input[name="host"]').first(); + this.portInput = page.locator('input[name="port"]').first(); + this.loginInput = page.locator('input[name="login"]').first(); + this.passwordInput = page.locator('input[name="password"], input[type="password"]').first(); + this.schemaInput = page.locator('input[name="schema"]').first(); + // Try multiple possible selectors + this.descriptionInput = page.locator('[name="description"]').first(); + + // Alerts + this.successAlert = page.locator('[data-scope="toast"][data-part="root"]'); + + // Delete confirmation dialog + this.confirmDeleteButton = page.locator('button:has-text("Delete")').first(); + + // Pagination + this.paginationNextButton = page.locator('[data-testid="next"]'); + this.paginationPrevButton = page.locator('[data-testid="prev"]'); + this.rowsPerPageSelect = page.locator("select"); + + // Sorting and filtering + this.tableHeader = page.locator('[role="columnheader"]').first(); + this.connectionIdHeader = page.locator('[role="columnheader"]:has-text("Connection ID")').first(); + this.connectionTypeHeader = page.locator('[role="columnheader"]:has-text("Connection Type")').first(); + this.hostHeader = page.locator('[role="columnheader"]:has-text("Host")').first(); + this.searchInput = page.locator('input[placeholder*="Search"], input[placeholder*="search"]').first(); + } + + // Click the Add button to create a new connection + public async clickAddButton(): Promise<void> { + await expect(this.addButton).toBeVisible({ timeout: 5000 }); + await expect(this.addButton).toBeEnabled({ timeout: 5000 }); + await this.addButton.click(); + // Wait for form to load + await expect(this.connectionForm).toBeVisible({ timeout: 10_000 }); + } + + // Click edit button for a specific connection + public async clickEditButton(connectionId: string): Promise<void> { + const row = await this.findConnectionRow(connectionId); + + if (!row) { + throw new Error(`Connection ${connectionId} not found`); + } + + const editButton = row.getByRole("button", { name: "Edit Connection" }); + + await expect(editButton).toBeVisible({ timeout: 5000 }); + await expect(editButton).toBeEnabled({ timeout: 5000 }); + await editButton.click(); + await expect(this.connectionForm).toBeVisible({ timeout: 10_000 }); + } + + public async clickNextPage(): Promise<void> { + const isEnabled = await this.paginationNextButton.isEnabled({ timeout: 3000 }).catch(() => false); + + if (!isEnabled) { + return; + } + + const initialIds = await this.getConnectionIds(); + + // Set up API listener before action + const responsePromise = this.page + .waitForResponse((resp) => resp.url().includes("/connections") && resp.status() === 200, { + timeout: 10_000, + }) + .catch(() => { + /* API might be cached */ + }); + + await expect(this.paginationNextButton).toBeVisible({ timeout: 5000 }); + await this.paginationNextButton.click(); + + // Wait for API response + await responsePromise; + + // Wait for UI to actually change + await expect + .poll(() => this.getConnectionIds(), { + message: "List did not update after clicking next page", + timeout: 10_000, + }) + .not.toEqual(initialIds); + } + + public async clickPrevPage(): Promise<void> { + const isEnabled = await this.paginationPrevButton.isEnabled({ timeout: 3000 }).catch(() => false); + + if (!isEnabled) { + return; + } + + const initialIds = await this.getConnectionIds(); + + // Set up API listener before action + const responsePromise = this.page + .waitForResponse((resp) => resp.url().includes("/connections") && resp.status() === 200, { + timeout: 10_000, + }) + .catch(() => { Review Comment: Do we need catch? ########## airflow-core/src/airflow/ui/tests/e2e/pages/ConnectionsPage.ts: ########## @@ -0,0 +1,622 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { expect, type Locator, type Page } from "@playwright/test"; +import { BasePage } from "tests/e2e/pages/BasePage"; + +type ConnectionDetails = { + conn_type: string; + connection_id: string; + description?: string; + extra?: string; + host?: string; + login?: string; + password?: string; + port?: number | string; + schema?: string; +}; + +export class ConnectionsPage extends BasePage { + // Page URLs + public static get connectionsListUrl(): string { + return "/connections"; + } + + public readonly addButton: Locator; + public readonly confirmDeleteButton: Locator; + public readonly connectionForm: Locator; + public readonly connectionIdHeader: Locator; + public readonly connectionIdInput: Locator; + // Core page elements + public readonly connectionsTable: Locator; + public readonly connectionTypeHeader: Locator; + public readonly connectionTypeSelect: Locator; + public readonly descriptionInput: Locator; + public readonly emptyState: Locator; + public readonly hostHeader: Locator; + public readonly hostInput: Locator; + public readonly loginInput: Locator; + + // Pagination elements + public readonly paginationNextButton: Locator; + public readonly paginationPrevButton: Locator; + public readonly passwordInput: Locator; + + public readonly portInput: Locator; + public readonly rowsPerPageSelect: Locator; + public readonly saveButton: Locator; + + public readonly schemaInput: Locator; + public readonly searchInput: Locator; + public readonly successAlert: Locator; + // Sorting and filtering + public readonly tableHeader: Locator; + public readonly testConnectionButton: Locator; + + public constructor(page: Page) { + super(page); + // Table elements (Chakra UI DataTable) + this.connectionsTable = page.locator('[role="grid"], table'); + this.emptyState = page.locator("text=/No connection found!/i"); + + // Action buttons + this.addButton = page.getByRole("button", { name: "Add Connection" }); + this.testConnectionButton = page.locator('button:has-text("Test")'); + this.saveButton = page.getByRole("button", { name: /^save$/i }); + + // Form inputs (Chakra UI inputs) + this.connectionForm = page.locator('[data-scope="dialog"][data-part="content"]'); + this.connectionIdInput = page.locator('input[name="connection_id"]').first(); + this.connectionTypeSelect = page.getByRole("combobox").first(); + this.hostInput = page.locator('input[name="host"]').first(); + this.portInput = page.locator('input[name="port"]').first(); + this.loginInput = page.locator('input[name="login"]').first(); + this.passwordInput = page.locator('input[name="password"], input[type="password"]').first(); + this.schemaInput = page.locator('input[name="schema"]').first(); + // Try multiple possible selectors + this.descriptionInput = page.locator('[name="description"]').first(); + + // Alerts + this.successAlert = page.locator('[data-scope="toast"][data-part="root"]'); + + // Delete confirmation dialog + this.confirmDeleteButton = page.locator('button:has-text("Delete")').first(); + + // Pagination + this.paginationNextButton = page.locator('[data-testid="next"]'); + this.paginationPrevButton = page.locator('[data-testid="prev"]'); + this.rowsPerPageSelect = page.locator("select"); + + // Sorting and filtering + this.tableHeader = page.locator('[role="columnheader"]').first(); + this.connectionIdHeader = page.locator('[role="columnheader"]:has-text("Connection ID")').first(); + this.connectionTypeHeader = page.locator('[role="columnheader"]:has-text("Connection Type")').first(); + this.hostHeader = page.locator('[role="columnheader"]:has-text("Host")').first(); + this.searchInput = page.locator('input[placeholder*="Search"], input[placeholder*="search"]').first(); + } + + // Click the Add button to create a new connection + public async clickAddButton(): Promise<void> { + await expect(this.addButton).toBeVisible({ timeout: 5000 }); + await expect(this.addButton).toBeEnabled({ timeout: 5000 }); + await this.addButton.click(); + // Wait for form to load + await expect(this.connectionForm).toBeVisible({ timeout: 10_000 }); + } + + // Click edit button for a specific connection + public async clickEditButton(connectionId: string): Promise<void> { + const row = await this.findConnectionRow(connectionId); + + if (!row) { + throw new Error(`Connection ${connectionId} not found`); + } + + const editButton = row.getByRole("button", { name: "Edit Connection" }); + + await expect(editButton).toBeVisible({ timeout: 5000 }); + await expect(editButton).toBeEnabled({ timeout: 5000 }); + await editButton.click(); + await expect(this.connectionForm).toBeVisible({ timeout: 10_000 }); + } + + public async clickNextPage(): Promise<void> { + const isEnabled = await this.paginationNextButton.isEnabled({ timeout: 3000 }).catch(() => false); + + if (!isEnabled) { + return; + } + + const initialIds = await this.getConnectionIds(); + + // Set up API listener before action + const responsePromise = this.page + .waitForResponse((resp) => resp.url().includes("/connections") && resp.status() === 200, { + timeout: 10_000, + }) + .catch(() => { Review Comment: do we need catch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
