vincbeck commented on code in PR #61647:
URL: https://github.com/apache/airflow/pull/61647#discussion_r2799843983
##########
providers/fab/src/airflow/providers/fab/auth_manager/fab_auth_manager.py:
##########
@@ -198,11 +198,15 @@ def get_cli_commands() -> list[CLICommand]:
def get_fastapi_app(self) -> FastAPI | None:
"""Get the FastAPI app."""
- from airflow.providers.fab.auth_manager.api_fastapi.routes.login
import (
- login_router,
+ from airflow.providers.fab.auth_manager.api_fastapi.routes import (
+ login as _login, # noqa: F401
+ roles as _roles, # noqa: F401
+ users as _users, # noqa: F401
+ )
Review Comment:
But you do not use these imports, dont you?
##########
providers/fab/src/airflow/providers/fab/auth_manager/fab_auth_manager.py:
##########
@@ -198,11 +198,15 @@ def get_cli_commands() -> list[CLICommand]:
def get_fastapi_app(self) -> FastAPI | None:
"""Get the FastAPI app."""
- from airflow.providers.fab.auth_manager.api_fastapi.routes.login
import (
- login_router,
+ from airflow.providers.fab.auth_manager.api_fastapi.routes import (
+ login as _login, # noqa: F401
+ roles as _roles, # noqa: F401
+ users as _users, # noqa: F401
+ )
Review Comment:
But you do not use these imports, do you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
