bugraoz93 commented on code in PR #61525:
URL: https://github.com/apache/airflow/pull/61525#discussion_r2801588639
##########
airflow-ctl/src/airflowctl/api/operations.py:
##########
@@ -554,20 +554,36 @@ def get(self, dag_id: str, dag_run_id: str) ->
DAGRunResponse | ServerResponseEr
def list(
self,
- dag_id: str,
- start_date: datetime.datetime,
- end_date: datetime.datetime,
- state: str,
- limit: int,
+ start_date: datetime.datetime | None = None,
+ end_date: datetime.datetime | None = None,
+ state: str | None = None,
Review Comment:
https://github.com/apache/airflow/blob/327201f5f9198ab3d19c1a07b8a39bcd0f61a7c4/airflow-core/src/airflow/api_fastapi/core_api/datamodels/dag_run.py#L79
Unfortunately, some fields cannot be `None` due to the API side of it. We
can follow the same approach as how you set a default variable for them. Could
you please double-check with the datamodel? I think some can indeed, such as
end_date, but some canno,t such as state
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
