n-badtke-cg commented on code in PR #61853:
URL: https://github.com/apache/airflow/pull/61853#discussion_r2803894698


##########
chart/values.schema.json:
##########
@@ -13728,7 +13728,7 @@
                     "default": 15
                 },
                 "retentionMinutes": {
-                    "description": "Number of minutes to retain the logs when 
running the Airflow log groomer sidecar.",
+                    "description": "Total retention time is retentionDays + 
retentionMinutes.",

Review Comment:
   Was there a mishap with this commit? ^^ you replaced the description instead 
of adding :)



##########
chart/values.schema.json:
##########
@@ -13727,6 +13727,11 @@
                     "type": "integer",
                     "default": 15
                 },
+                "retentionMinutes": {
+                    "description": "Number of minutes to retain the logs when 
running the Airflow log groomer sidecar.",
+                    "type": "integer",
+                    "default": 0
+                },

Review Comment:
   I meant to both retentionDays and retentionMinutes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to