This is an automated email from the ASF dual-hosted git repository. rahulvats pushed a commit to branch fix/favorite-filter-star-icon-visibility in repository https://gitbox.apache.org/repos/asf/airflow.git
commit 50f0d4f3e8c9f8cb39064c0d2bc3816da3de07d1 Author: vatsrahul1001 <[email protected]> AuthorDate: Fri Feb 13 20:30:32 2026 +0530 fix(ui): Fix star icon visibility in Favorite filter buttons when selected --- .../ui/src/pages/DagsList/DagsFilters/FavoriteFilter.tsx | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/airflow-core/src/airflow/ui/src/pages/DagsList/DagsFilters/FavoriteFilter.tsx b/airflow-core/src/airflow/ui/src/pages/DagsList/DagsFilters/FavoriteFilter.tsx index a825b11c68e..546644e357a 100644 --- a/airflow-core/src/airflow/ui/src/pages/DagsList/DagsFilters/FavoriteFilter.tsx +++ b/airflow-core/src/airflow/ui/src/pages/DagsList/DagsFilters/FavoriteFilter.tsx @@ -29,6 +29,8 @@ export const FavoriteFilter = ({ onFavoriteChange, showFavorites }: Props) => { const { t: translate } = useTranslation("dags"); const currentValue = showFavorites ?? "all"; + const isFavoriteSelected = currentValue === "true"; + const isUnfavoriteSelected = currentValue === "false"; return ( <ButtonGroup attached size="sm" variant="outline"> @@ -44,9 +46,9 @@ export const FavoriteFilter = ({ onFavoriteChange, showFavorites }: Props) => { colorPalette="brand" onClick={onFavoriteChange} value="true" - variant={currentValue === "true" ? "solid" : "outline"} + variant={isFavoriteSelected ? "solid" : "outline"} > - <Icon asChild color="brand.solid"> + <Icon asChild color={isFavoriteSelected ? "brand.contrast" : "brand.solid"}> <FiStar style={{ fill: "currentColor" }} /> </Icon> {translate("filters.favorite.favorite")} @@ -55,9 +57,9 @@ export const FavoriteFilter = ({ onFavoriteChange, showFavorites }: Props) => { colorPalette="brand" onClick={onFavoriteChange} value="false" - variant={currentValue === "false" ? "solid" : "outline"} + variant={isUnfavoriteSelected ? "solid" : "outline"} > - <Icon asChild color="fg.muted"> + <Icon asChild color={isUnfavoriteSelected ? "brand.contrast" : "brand.solid"}> <FiStar /> </Icon> {translate("filters.favorite.unfavorite")}
