(airflow) branch v3-1-test updated: fix(ui): Fix star icon visibility in Favorite filter buttons when selected (#61862)

[bbovenzi]

This is an automated email from the ASF dual-hosted git repository.

bbovenzi pushed a commit to branch v3-1-test
in repository https://gitbox.apache.org/repos/asf/airflow.git


The following commit(s) were added to refs/heads/v3-1-test by this push:
     new c52485ea3e4 fix(ui): Fix star icon visibility in Favorite filter 
buttons when selected (#61862)
c52485ea3e4 is described below

commit c52485ea3e48c2d07f71394c25e72dd1092cb8be
Author: Rahul Vats <43964496+vatsrahul1...@users.noreply.github.com>
AuthorDate: Fri Feb 13 21:36:13 2026 +0530

    fix(ui): Fix star icon visibility in Favorite filter buttons when selected 
(#61862)
---
 .../ui/src/pages/DagsList/DagsFilters/FavoriteFilter.tsx       | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git 
a/airflow-core/src/airflow/ui/src/pages/DagsList/DagsFilters/FavoriteFilter.tsx 
b/airflow-core/src/airflow/ui/src/pages/DagsList/DagsFilters/FavoriteFilter.tsx
index a825b11c68e..546644e357a 100644
--- 
a/airflow-core/src/airflow/ui/src/pages/DagsList/DagsFilters/FavoriteFilter.tsx
+++ 
b/airflow-core/src/airflow/ui/src/pages/DagsList/DagsFilters/FavoriteFilter.tsx
@@ -29,6 +29,8 @@ export const FavoriteFilter = ({ onFavoriteChange, 
showFavorites }: Props) => {
   const { t: translate } = useTranslation("dags");
 
   const currentValue = showFavorites ?? "all";
+  const isFavoriteSelected = currentValue === "true";
+  const isUnfavoriteSelected = currentValue === "false";
 
   return (
     <ButtonGroup attached size="sm" variant="outline">
@@ -44,9 +46,9 @@ export const FavoriteFilter = ({ onFavoriteChange, 
showFavorites }: Props) => {
         colorPalette="brand"
         onClick={onFavoriteChange}
         value="true"
-        variant={currentValue === "true" ? "solid" : "outline"}
+        variant={isFavoriteSelected ? "solid" : "outline"}
       >
-        <Icon asChild color="brand.solid">
+        <Icon asChild color={isFavoriteSelected ? "brand.contrast" : 
"brand.solid"}>
           <FiStar style={{ fill: "currentColor" }} />
         </Icon>
         {translate("filters.favorite.favorite")}
@@ -55,9 +57,9 @@ export const FavoriteFilter = ({ onFavoriteChange, 
showFavorites }: Props) => {
         colorPalette="brand"
         onClick={onFavoriteChange}
         value="false"
-        variant={currentValue === "false" ? "solid" : "outline"}
+        variant={isUnfavoriteSelected ? "solid" : "outline"}
       >
-        <Icon asChild color="fg.muted">
+        <Icon asChild color={isUnfavoriteSelected ? "brand.contrast" : 
"brand.solid"}>
           <FiStar />
         </Icon>
         {translate("filters.favorite.unfavorite")}